Ensure that "true" and "false" won't go in same bucket in hash table #3471
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-torrance
force-pushed
the
bool-hash
branch
3 times, most recently
from
9665b86
to
b9bd9c7
Compare
|
What if we treated true and false as 0/1 like in C? |
|
Works for me! |
d-torrance
force-pushed
the
bool-hash
branch
from
b9bd9c7
to
2123cf6
Compare
|
I think just wait until the other one is merged first. |
d-torrance
force-pushed
the
bool-hash
branch
from
2123cf6
to
0fdbdfb
Compare
Previously, "hash true" and "hash false" were both congruent to 1 (mod 4). We just set them to 1 and 0, resp. Also update the corresponding basic test.
d-torrance
force-pushed
the
bool-hash
branch
from
0fdbdfb
to
45df73f
Compare
mahrud
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't completely address #3468, but it at least does when the keys of the hash table are
trueandfalse.Before:
After
We also refactor the code mentioned in #3468 (comment) so it doesn't rely on the order of the elements returned byEdit: I removed this commit because it's already dealt with in #3469.values.Edit no. 2: I adjusted the hash of
falseto be congruent to 2 (mod 4) instead of 0 (mod 4) so that thetruebucket would go before thefalsebucket and the builds wouldn't fail w/o #3469.